prebid / prebid-universal-creative

Apache License 2.0
43 stars 69 forks source link

cookieSync code redundant; too noisy #212

Closed patmmccann closed 1 month ago

patmmccann commented 1 year ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce https://github.com/prebid/prebid-universal-creative/blob/master/src/cookieSync.js is far too noisy and shares lots of code with https://github.com/prebid/prebid-universal-creative/blob/master/src/cookieSyncWithConsent.js . They should not have code copy pastes and they should not console log so much.

load_cookie_with_consent.html and load_cookie.html should source the same js and be identical in any other way.

patmmccann commented 9 months ago

Bumping priority to high as cookie sync without consent getting flagged more often by community

dgirardi commented 7 months ago

What is getting flagged? Is this a bug, or a nice to have?

I'd be parsimonious with updating these as they are hard to test and harder to deploy. It's not clear to me that we even can do a comprehensive deployment - see https://github.com/prebid/prebid-universal-creative/issues/186

patmmccann commented 6 months ago

this is pretty big issue, we need both load-cookie htmls to have gpp consent

patmmccann commented 6 months ago

a publisher using the software was contacted by a government recently, potentially redundant with https://github.com/prebid/prebid-universal-creative/issues/213