search

prebid / prebid.github.io

Repo that controls Prebid.org website
http://prebid.org
Apache License 2.0
68 stars 1.18k forks source link

Update docs for Vox adapter #5433

Closed Gradi closed 3 months ago

Gradi commented 3 months ago

Good day,

This PR updates docs for Vox adapter.

More context information

Some time ago we added a Vox adapter for PrebidServer. (Link), but, i suppose, we forgot to update documentation on this particular repository.

Moreover, we are listed in Prebid.js bidders list(Link), but we are not listed in PrebidServer bidders(Link), despite the fact that we added PrebidServer adapter about a year ago.

As far, as i understand, this happened because we forgot to add pbs:true flag to this repository.

🏷 Type of documentation

📋 Checklist

netlify[bot] commented 3 months ago

Deploy Preview for prebid-docs-preview ready!

Name Link
Latest commit caab463f81191619cc21d3b4da7483ee612b8461
Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/6670620613884200086cba99
Deploy Preview https://deploy-preview-5433--prebid-docs-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Gradi commented 3 months ago

I see our adapter has appeared in PrebidServer bidder list. Thanks to bot's preview link.

bretg commented 3 months ago

@Gradi - you're correct that adding the pbs: true flag will get you in the PBS bid adapters list.

However, I have concerns about this displaySizes parameter. What's the use case for this? Prebid assumes that every bidder is going to limit their display bid responses to the sizes in imp.banner.formats. If this displaySizes parameter includes a size that is not in imp.banner.formats, it could create an error condition if a host company has turned on size validation.

Gradi commented 3 months ago

@bretg displaySizes specifies valid banner sizes which could fit onto picture (inImage format). If publisher wants a classic banner, he will use imp.banner.formats.

However, I agree that those two parameters overlap a bit.

bretg commented 3 months ago

What is "inimage"?

Gradi commented 3 months ago

@bretg It is our ad format. Banner placed on top of image itself. You can see demo 1 and demo 2 (don't forget to turn off ad blocker).

Our frontend script checks image size and sends array of banner sizes which could fit onto particular picture (that is displaySizes)

bretg commented 3 months ago

Interesting unit. Ok - please be warned that some Prebid Server hosts might turn on the auction.bid-validations.banner-creative-max-size feature which will discard any bids that are wider than the widest imp.banner.format or taller than the tallest imp.banner.format. I would recommend making sure your script that determines sizes stays within that set of dimensions.