prebid / prebid.github.io

Repo that controls Prebid.org website
http://prebid.org
Apache License 2.0
68 stars 1.18k forks source link

Adkernel: documenting global_sun alias #5471

Closed ckbo3hrk closed 1 month ago

ckbo3hrk commented 3 months ago

🏷 Type of documentation

📋 Checklist

netlify[bot] commented 3 months ago

Deploy Preview for prebid-docs-preview ready!

Name Link
Latest commit bcb39a3e16b843bfca598f2a302d3bcb05a5d296
Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/66bb24ead6211f0009ade709
Deploy Preview https://deploy-preview-5471--prebid-docs-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

muuki88 commented 2 months ago

Why are there two globalsun adapter docs in the PR? @ckbo3hrk

patmmccann commented 2 months ago

There are now two adapters with the same name :(

Should we revert the alias pr?

ckbo3hrk commented 2 months ago

There are now two adapters with the same name :(

Should we revert the alias pr?

@patmmccann I've contacted the partner network and they made a pull request to remove obsolete adapter https://github.com/prebid/Prebid.js/pull/11972

patmmccann commented 2 months ago

That's a breaking change though if anyone has it in their build script their build will break

patmmccann commented 2 months ago

Can you change the alias name to global_sun? We have precedent with this for emxdigital

patmmccann commented 2 months ago

we reverted the alias, feel free to pick a new name https://github.com/prebid/Prebid.js/pull/11983

ckbo3hrk commented 2 months ago

Is there anything else we need to do to merge this pull request?