search

prebid / professor-prebid

Prebid's next-gen debugging tool
Apache License 2.0
23 stars 20 forks source link

gam links broken for mcm pubs #25

Closed patmmccann closed 2 years ago

patmmccann commented 2 years ago

Going to https://firstquarterfinance.com/, one sees for example:

https://admanager.google.com/18190176,22497559205#delivery/LineItemDetail/lineItemId=604570136

should be

https://admanager.google.com/18190176#delivery/LineItemDetail/lineItemId=604570136

Same problem at

https://dinnerthendessert.com/cinnamon-roll-monkey-bread/ https://admanager.google.com/1030006,22613210658#delivery/LineItemDetail/lineItemId=5219256474 should be https://admanager.google.com/1030006#delivery/LineItemDetail/lineItemId=5219256474

florianerl commented 2 years ago

hi @patmmccann ,

the issue should be fixed with the latest version. Please let me know in case it isn't.

patmmccann commented 2 years ago

I am running 0.2.45 It seems to be fixed for query id but not lineitem id. What version is the fix in?

patmmccann commented 2 years ago

https://github.com/prebid/professor-prebid/pull/29/files#r937905500

florianerl commented 2 years ago

hi @patmmccann ,

big sorry! I just published a new version. please let me know if this one is working for you now 🙏

patmmccann commented 2 years ago

confirming fixed, ty!!!