search

prebid / professor-prebid

Prebid's next-gen debugging tool
Apache License 2.0
23 stars 20 forks source link

Check for non-consented vendor calls #65

Open patmmccann opened 1 year ago

patmmccann commented 1 year ago

We'd love to flag non-consented vendors appearing in user syncs and markups. The google additional consent list has a map of domain to gvl id and acl id at https://storage.googleapis.com/tcfac/additional-consent-providers.csv

patmmccann commented 1 year ago

related: https://github.com/prebid/Prebid.js/issues/9088

pm-harshad-mane commented 1 year ago

We will need to generate a chain of network calls initiated by prebid modules (bidders, user-id modules). The Chrome Network panel helps but we will need to putt extra checks and highlight when a signal is not passed by a partner. The Proff Prebid should not always run this analysis, this flow should be initiated at user request.

pm-harshad-mane commented 1 year ago

Jason is working on generating a chain of network calls initiated in user-sync process to display in the Professor Prebid

jlquaccia commented 1 year ago

Hi @patmmccann @ChrisHuie @pm-harshad-mane (feel free to tag anyone else that you think should be included on this thread as well)

Just created a PR (linked above to this issue ticket) for the first iteration of a tool within Prof Prebid that can generate a chain of network calls that initiate based on a provided user sync URL. Under the hood this tool relies on Chrome's devtools network API. I've created a quick video demonstrating what I've built out so far to make things easier to visualize (the video also explains how to use the tool): https://vimeo.com/835964741

Since this is a POC, I'm definitely expecting feedback, so was curious to see what your thoughts on this are and what the "next steps" might look like. Some known "todo-items" for improvement based on some feedback I have already come across include the following:

florianerl commented 1 year ago

Hi @jlquaccia ,

thanks a lot for your PR! I applied your changes to https://github.com/prebid/professor-prebid/tree/version-0.2.64. I have created a dev-tool-panel in version 0.2.63 and added it directly there: image Let me know what you think please

jlquaccia commented 1 year ago

Hey @florianerl,

No problem! Also, nice! I will take a look soon this week and get back to you.

jlquaccia commented 1 year ago

Hey @florianerl,

Getting around to some more Prof Prebid work this week. Nice, looks good where you put the module I made! Just took a look on the branch that you mentioned above. I'm planning on addressing some changes this week to the Network Inspector module I was working on.. which includes the following:

Will update you once I have a new PR ready to be reviewed.

florianerl commented 1 year ago

Hi @jlquaccia ,

what do you think of using typescript for src/pages/Devtools/index.js ? Just for the sakes of uniformity?

jlquaccia commented 1 year ago

Hey Florian,

Ah, good call out. Yes, I can definitely use TypeScript in that file 👍

On Wed, Jun 28, 2023 at 1:19 AM Florian Erl @.***> wrote:

Hi @jlquaccia https://github.com/jlquaccia ,

what do you think of using typescript for src/pages/Devtools/index.js ? Just for the sakes of uniformity?

— Reply to this email directly, view it on GitHub https://github.com/prebid/professor-prebid/issues/65#issuecomment-1610975719, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABX6NQY33DX7DKTNUVXLVKLXNPSKZANCNFSM6AAAAAAYNXEPN4 . You are receiving this because you were mentioned.Message ID: @.***>

jlquaccia commented 1 year ago

Hey @florianerl,

Just submitted a new PR addressing a few things, including converting src/pages/Devtools/index.js to now use TypeScript. Take a look when you have some time. The description on the PR contains more info about the changes I made.

PR: https://github.com/prebid/professor-prebid/pull/71