search

prebid / shared-id

Shared ID
Apache License 2.0
6 stars 7 forks source link

Collector script to use Async get eids function #40

Open patmmccann opened 2 years ago

patmmccann commented 2 years ago

https://github.com/prebid/Prebid.js/pull/8201 allows the collection of eids async. This is more likely to resolve.

@jdwieland8282 @SKOCHERI

patmmccann commented 2 years ago

https://github.com/prebid/shared-id/blob/5a5d368ea261191dc5597675289f1bd6716e2d29/pubcid.js/src/index.js#L9

dgirardi commented 2 years ago

Without knowing what gpt expects I would not blindly switch to the async function; it will sometimes provide an id when the sync version wouldn't, but it will be much slower on average.

patmmccann commented 2 years ago

So this behavior(signal collection) is built with an asynchronous nature. It is better to populate the signal slowly than populate quickly and missing.

dgirardi commented 1 year ago

@patmmccann - what is this issue about? should it be in the shared-id repo?

jdwieland8282 commented 1 year ago

Next steps:

  1. modify ob collector script to call async endpoint
  2. alert OB that we will be releasing a new version of the collector script
  3. coordinate the changes in https://github.com/prebid/shared-id/pull/42 with OB as well.
patmmccann commented 2 months ago

Should we simply deprecate this script? GAM can now find the sharedid

Image https://support.google.com/admanager/answer/10488752?hl=en