preble / JD-pyprocgame

New software for the Judge Dredd pinball machine, written against pyprocgame.
http://www.pinballcontrollers.com/
MIT License
16 stars 4 forks source link

Incorrect callouts for easy or hard Meltdown #4

Open clempo2 opened 3 years ago

clempo2 commented 3 years ago

When the 'Chain feature difficulty' is medium the number of shots required for Meltdown is 5. This produces a valid sequence of callouts as the switches are hit: 0 -> "power towers going critical.wav" 1 -> "reactor 1 stabilized.wav" 2 -> "reactor 2 stabilized.wav" 3 -> "reactor 3 stabilized.wav" 4 -> "reactor 4 stabilized.wav" 5 -> "all reactors stabilized.wav"

When the 'Chain feature difficulty' is easy the number of shots required for Meltdown is 3. This produces a sequence of callouts that never announces the end of the mode: 0 -> "power towers going critical.wav" 1 -> "reactor 1 stabilized.wav" 2 -> "reactor 2 stabilized.wav" 3 -> "reactor 3 stabilized.wav" The last callout should be "all reactors stabilized.wav"

When the 'Chain feature difficulty' is hard the number of shots required for Meltdown is 7. This produces a sequence of callouts that announces the end of the mode prematurely: 0 -> "power towers going critical.wav" 1 -> "reactor 1 stabilized.wav" 2 -> "reactor 2 stabilized.wav" 3 -> "reactor 3 stabilized.wav" 4 -> "reactor 4 stabilized.wav" 5 -> "all reactors stabilized.wav" 6 -> "all reactors stabilized.wav" 7 -> "all reactors stabilized.wav"

There are no callouts for 5 or 6 reactors. The easiest way to deal with the missing sound files is to change the number of shots required easy -> 3 medium -> 4 hard -> 5

clempo2 commented 3 years ago

The issue can be reproduced with the attached test case test.zip