search

preboot / angular-webpack

A complete, yet simple, starter for Angular v2+ using webpack
MIT License
1.29k stars 557 forks source link

Sass not supported #224

Closed mnn closed 7 years ago

mnn commented 7 years ago

Project readme claims support of Sass:

Stylesheets with SASS (not required, it supports regular css too).

Yet it doesn't seem to be supported at all:

Error in ./src/app/test/test.sass
Module parse failed: /xxx/src/app/test/test.sass Unexpected token (1:0)
You may need an appropriate loader to handle this file type.
*
    color: orange
Foxandxss commented 7 years ago

I am really ignorant on this CSS pre processors. Isn't 'scss' the same as 'sass'? We are using .scss as the extension. But we can activate .sass as well.

mnn commented 7 years ago

SCSS and SASS format differ (SCSS is a bit enhanced CSS - mainly scoping, SASS goes even further and allows e.g. to omit { } ;).

Googled a bit and fix is suprisingly simple - just modify regexes from /\.scss$/ to /\.(scss|sass)$/.

Foxandxss commented 7 years ago

yup, is pretty much that. Create a PR if you want or I can fix that myself.

mnn commented 7 years ago

PR #225 should fix it, closing this issue.