Open phil123456 opened 7 years ago
I think there is a no-unused-var setting. But can't you just leave the args out?
On 30 Mar 2017 10:03, "phil123456" notifications@github.com wrote:
Hi,
I tried to put my code in that seed, but I keep getting these although I set "no-unused-expression": false, in tslint.json (not sure this suffice or is related)
these errors are all over the place, I tried commenting and removing unused stuffs, but here in a pipe, I dont need to use args parameter
can you hint me how to sort this ? why does it stop compilation at all ?
thanks
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/preboot/angular-webpack/issues/325, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWx9uw01DOpkdMfN-_KeHglS59E11JHks5rq2GygaJpZM4Mt_-Z .
I commented the args, but I dont like that, they are default pie transform args, thought it would be better to leave them in case I want to use them
no there is no no-unused-var setting, I'll give it a try
actually it would be better to leave that on and ignore some cases
Hm, im mistaken then. You could either comment it out/remove it, or add a tslint ignore line above it
On Thu, Mar 30, 2017 at 10:37 AM, phil123456 notifications@github.com wrote:
I commented the args, but I dont like that, they are default pie transform args, thought it would be better to leave them in case I want to use them
no there is no no-unused-var setting, I'll give it a try
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/preboot/angular-webpack/issues/325#issuecomment-290341905, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWx9mSxj2H4kseGQ_ZBpppPZVKid6R_ks5rq2njgaJpZM4Mt_-Z .
I tried tslint ignore with no luck
btw I get tons of
[42, 9]: if statements must be braced [44, 9]: else statements must be braced [50, 9]: if statements must be braced [52, 9]: else statements must be braced [26, 23]: " should be ' [26, 61]: " should be ' [5, 31]: Missing semicolon [45, 40]: Missing semicolon
in chrome console, I think it's a nice feature, but is there no way to disable some of these ? like having to put ' instead of " is really not my cup of tea and I am not sure it is really necessary
Thats all configurable in the TSHint json file. That's no issue from this starter
On a personal note, it's better to follow the conventions in the long run.
ok, thanks nice seed so far ;-)
The noUnusedLocals
and noUnusedParameters
rules are not in tslint anymore but are now part of the TypeScript transpiler itself, both are set to true in tsconfig.json
. You can prefix the name of an unused arg with an underscore to exempt it from the rule.
nice, thanks
Hi,
I tried to put my code in that seed, but I keep getting these although I set "no-unused-expression": false, in tslint.json (not sure this suffice or is related)
these errors are all over the place, I tried commenting and removing unused stuffs, but here in a pipe, I dont need to use args parameter
can you hint me how to sort this ? why does it stop compilation at all ?
thanks