preboot / angular-webpack

A complete, yet simple, starter for Angular v2+ using webpack
MIT License
1.29k stars 556 forks source link

LoaderOptionsPlugin #346

Open dland512 opened 7 years ago

dland512 commented 7 years ago

Great webpack starter. Thanks for putting it together. Quick question for you. I see that it's using LoaderOptionsPlugin. I'm still a bit new to Webpack so there could be a good reason for it but I was wondering why we are going that route rather than just putting the config options in the loader declarations themselves. For example, for tslint-loader, doing this:

{
    test: /\.ts$/,
    loader: 'tslint-loader',
    options: {
        emitErrors: true,
        failOnHint: true
    }
}

Seems to work just as well as using the plugin:

new webpack.LoaderOptionsPlugin({
    options: {
        tslint: {
            emitErrors: true,
            failOnHint: true
       }
}

Again, this could very well be based on my not understanding something correctly, so I'm more just asking for the sake of learning.

Foxandxss commented 7 years ago

supposedly the former way was deprecated in 2.0 and the latter is the recommended one. Not sure if that changed again over time.