search

preboot / angularjs-webpack

A complete, yet simple, starter for AngularJS using webpack
MIT License
1.71k stars 658 forks source link

Add explicit browserslist config #99

Closed dkokic closed 6 years ago

dkokic commented 6 years ago

As browserslist is already being used by autoprefixer here the explicit (recommended) config in package.json

Should help resolve #91 (and consequently #95)

dkokic commented 6 years ago

Done.

dkokic commented 6 years ago

ups ;-)

On 24 May 2018 at 17:20, Francesco Soncina notifications@github.com wrote:

@phra requested changes on this pull request.

In .browserslistrc https://github.com/preboot/angularjs-webpack/pull/99#discussion_r190627479 :

@@ -0,0 +1,10 @@ +{

  • "production": [
  • "> 1%",
  • "ie 10"
  • ],
  • "development": [
  • "last 1 chrome version",
  • "last 1 firefox version"
  • ] +}

the syntax for .browserslistsrc is different frompackage.json` one. see https://www.npmjs.com/package/browserslist#environments and update the PR.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/preboot/angularjs-webpack/pull/99#pullrequestreview-123044407, or mute the thread https://github.com/notifications/unsubscribe-auth/AANDjjlE_HUS3EuP9v4xTV4FawzsPgrfks5t1s-qgaJpZM4Tz-k1 .