search

prebuild / docker-images

Docker images for cross compiling prebuilt binaries for Node.js native addons.
GNU General Public License v3.0
10 stars 7 forks source link

Install python 3 on images #15

Closed vweevers closed 2 years ago

vweevers commented 3 years ago

Required for latest node-gyp.

The centos7-devtoolset7 image has python 2, I didn't check the other images yet.

PRs welcome.

reconbot commented 2 years ago

Is there a workaround to install python 3? I'm having trouble building with python 2 and node 14

reconbot commented 2 years ago

alpine also has python2 - doesn't seem to let us install any packages eg -i alpine --preinstall 'apk add python3' doesn't work.

vweevers commented 2 years ago

I'm guessing because that runs as the node user.

A PR to move to Python 3 would be most welcome.

vweevers commented 2 years ago

(short of that, the only workaround is downgrading node-gyp)

GazHank commented 2 years ago

hi @reconbot, I've proposed PR https://github.com/prebuild/docker-images/pull/22 to add python 3 to Centos and Alpine. Any testing or feedback would be welcome. Sorry I've not had chance to test this out properly yet (I'm away from my dev machines at the moment)

reconbot commented 2 years ago

How can I test it?

GazHank commented 2 years ago

How can I test it?

I think the easiest way is using a custom image per https://github.com/prebuild/prebuildify-cross#usage but haven't had chance to try it yet

vweevers commented 2 years ago

2.0.0