search

prebuild / docker-images

Docker images for cross compiling prebuilt binaries for Node.js native addons.
GNU General Public License v3.0
10 stars 7 forks source link

Python 3.x upgrade has broken yum on `centos7-devtoolset7` #28

Closed thegecko closed 1 year ago

thegecko commented 1 year ago

Since the python 3.x upgrade, yum seems to be broken on the centos7-devtoolset7 image.

Using the following dockerfile:

FROM ghcr.io/prebuild/centos7-devtoolset7:2.1.0
USER 0

RUN yum install -y libudev-devel

USER node

Yields errors with yum accessing the correct python version:

#6 2.378   File "/usr/libexec/urlgrabber-ext-down", line 28
#6 2.378     except OSError, e:
#6 2.378                   ^
#6 2.378 SyntaxError: invalid syntax

I'll try some sed magic...

vweevers commented 1 year ago

I thought I handled that with:

https://github.com/prebuild/docker-images/blob/4b8968f7b0adda2b6cc5576526de270dd31c904b/centos7-devtoolset7/Dockerfile#L9

But I don't remember the extent to which I tested that.

thegecko commented 1 year ago

But I don't remember the extent to which I tested that.

Seems it needs to be replaced in a different script, too.

29 fixes the issue