search

prebuild / docker-images

Docker images for cross compiling prebuilt binaries for Node.js native addons.
GNU General Public License v3.0
10 stars 7 forks source link

Fix python in urlgrabber-ext-down #29

Closed thegecko closed 1 year ago

thegecko commented 1 year ago

Replace python version in /usr/libexec/urlgrabber-ext-down to fix yum on centos7-devtoolset7

Fixes https://github.com/prebuild/docker-images/issues/28

vweevers commented 1 year ago

@thegecko Tests failed on master, could you have a look? https://github.com/prebuild/docker-images/actions/runs/3665704437/jobs/6196951730

thegecko commented 1 year ago

Hmm, took a quick look.

It seems to fail before my change when installing Node. This could be a new failure due to dependency changes in node 18 (and it being the new LTS).

Did node 18 build in this container before?

vweevers commented 1 year ago

This could be a new failure due to dependency changes in node 18

Ah right. Node 18 is incompatible with CentOS 7, so until we upgrade (https://github.com/prebuild/prebuildify-cross/issues/13) I will pin node to 16.

vweevers commented 1 year ago

2.1.1