search

prebuild / prebuild

A command line tool for easily doing prebuilds for multiple version of node on a specific platform
MIT License
432 stars 75 forks source link

Merge in prebuildify and release as new major #168

Closed mafintosh closed 5 years ago

mafintosh commented 7 years ago

As soon as @juliangruber finishes all his awesome CI build stuff we should just merge in prebuildify here and release as a new major

ralphtheninja commented 7 years ago

Consider renaming --preinstall and --postinstall to just --pre and --post

fanatid commented 7 years ago

@mafintosh sorry, can you give more details? What CI build stuff @juliangruber develop? prebuild-ci? Do you want to move part of prebuildify to prebuild?

juliangruber commented 7 years ago

@fanatid we're working on a flow where you use prebuild-ci to build your releases on CI and upload them to github, then use travis-watch (and the to-be-written appveyor-watch) to wait until all are done, then publish them inside the node module with the prebuildify approach

fanatid commented 7 years ago

@juliangruber thank you for explanation, looks similar to what I suggested in https://github.com/mafintosh/prebuildify/issues/6#issuecomment-286426552 prebuildify will be deprecated after new prebuild major version, I'm understand correctly?

juliangruber commented 7 years ago

ah, nice! yes, after its functionality has been merged into prebuild

piranna commented 7 years ago

What's the difference between prebuild and prebuildify?

ralphtheninja commented 7 years ago

@piranna https://github.com/mafintosh/prebuildify

ralphtheninja commented 7 years ago

@piranna Basically, bundle the prebuilds inside the npm package when publishing.

piranna commented 7 years ago

@piranna Basically, bundle the prebuilds inside the npm package when publishing.

So they binaries will be inside the tarball served by npm registry? I find this bad... not only will give more presure to their servers and will download the binaries for ALL the platforms, but also would not offer tarballs for the binaries as it's currently done when publishing on GitHub. I would like to still have an option to publish the prebuilds on Github, both automatically or by generating them and uploading them myself.

mathiask88 commented 7 years ago

@piranna The functionality of prebuildify will extend and not replace the current features of prebuild in my understanding. So the user can choose the way he wants to go. There are several pros and cons for both approaches.

piranna commented 7 years ago

The functionality of prebuildify will extend and not replace the current features of prebuild in my understanding

I was worried about that, my understand was that it was going to replace the current behaviour.

ralphtheninja commented 7 years ago

@piranna The functionality of prebuildify will extend and not replace the current features of prebuild in my understanding. So the user can choose the way he wants to go. There are several pros and cons for both approaches.

You said what I was about to say :)

So maybe then we shouldn't merge prebuild and prebuildify and just keep them as separate repositories.

vweevers commented 5 years ago

So maybe then we shouldn't merge prebuild and prebuildify and just keep them as separate repositories.

👍