search

prebuild / prebuildify

Create and package prebuilds for native modules
MIT License
198 stars 37 forks source link

Prefer locally-installed node-gyp #30

Closed vweevers closed 5 years ago

vweevers commented 5 years ago

Currently, prebuildify uses the node-gyp that's available in PATH and when npm runs scripts, it adds the global node_modules/npm-lifecycle/node-gyp-bin folder to PATH. Effectively, we're always using the npm-bundled version of node-gyp.

vweevers commented 5 years ago

@mafintosh @emilbayes @lpinca @lgeiger Any objections?

(Apologies if I've wrongly identified you as a prebuildify user)

mafintosh commented 5 years ago

@vweevers i thought npm prefixed the path with the local ones?

if not, yea if it can be done simply then 👍 obvs :)

vweevers commented 5 years ago

i thought npm prefixed the path with the local ones?

It still does that, but the path to the bundled node-gyp takes precedence over that local .bin folder. This has been the case since npm 5.6.0 (surprised me as well).

mafintosh commented 5 years ago

That's lame 👎 All for supporting that.

lpinca commented 5 years ago

No objections.