Upload binaries - Githubissues

fanatid commented 7 years ago

Don't you mind if I do PR which adds option for upload binaries to github? After we can create package prebuildify-download (like prebuild-install) This will helpful for #1

fanatid commented 7 years ago

@mafintosh re prebuildify-ci: should we add upload feature here or in prebuildify-ci? (I prefer here)

mafintosh commented 7 years ago

How would uploads/download work in general? The main idea here is that we bundle all prebuilds inside the tarball to avoid weird permission errors etc

fanatid commented 7 years ago

I thought that main benefit of prebuildify that bindings can work with any node/electron version. But of course prebuilds inside tarball is also important, because allow distribute bindings when user offline.

My thoughts about prebuildify-ci/prebuildify-download:

prebuildify-ci determine that commit is release (new version in package.json) and build prebuilds with prebuildify and upload to github (with prebuildify?)
if developer want distribute package with prebuilds in tarball he should download all prebuilds (windows/linux/mac) (prebuildify-download --all for example) and publish on npm
if developer does not want distribute package with prebuilds in tarball he can publish package immediately and prebuilds will be downloaded with prebuildify-download when package will be installed or compiled with node-gyp-build if required version not found

mafintosh commented 6 years ago

We added all this in prebuildify-ci. Works really great.

prebuild / prebuildify

Upload binaries #6