search

prebuild / prebuildify

Create and package prebuilds for native modules
MIT License
196 stars 37 forks source link

Prebuilding for multiple target does not work with 6.0.1 #90

Open Lesstat opened 4 months ago

Lesstat commented 4 months ago

We use prebuildify to prebuild for the target environments that we use and execute it something like this:

prebuildify -t 18.20.3 -t 20.13.1 -t electron@29.4.0 -t electron@30.0.6

With version 5.0.1 this resulted in 3 prebuilds with the names:

After upgrading to 6.0.1 we only get 1 prebuild with the name: my-package-name.node. This means the prebuild will only work in some environments and error in others. Prebuildify still runs three builds but I assume only the last one is available in the builds folder. Platform is Windows if that matters.

Totto16 commented 4 months ago

This also happens on linux, and not with 5.0.1

It seems, that what happens is:

In 5.0.1 it is called ${runtime}.${version}.node where runtime is electron or node, version is the node_module_version

And in 6.0.1 it is called ${name}.node Where name is the package name

It seems that they added the name, and forgot to add the other tags to the final name 🤷🏼‍♂️

Lesstat commented 3 months ago

I just tested the fix in #91 and it worked as expected for me.