search

precice / PreCICE.jl

Julia language bindings for preCICE
GNU Lesser General Public License v3.0
11 stars 1 forks source link

Remove depence on `whereis` command #22

Closed erikscheurer closed 2 years ago

erikscheurer commented 2 years ago

Closes #16 #21

This PR removes the dependence on the whereis command for finding the PreCICE library. This command also finds static libraries libprecice.a. However, Julia only can work with shared object libraries. By default Julia searches in the system library path LD_LIBRARY_PATH. Thereby, as long as PreCICE is in the system libraries, Julia will be able to find the library.

erikscheurer commented 2 years ago

We should look into, whether we need the build.jl for a custom installation path. What happens there may be reset every time Julia is restarted. And may not even be necessary if the PreCICE library is in the LD_LIBRARY_PATH. In my tests it worked fine without building the way stated in the README.md To test it, just copy and paste

$ julia
julia> ] add https://github.com/precice/julia-bindings.git#find_binary
pkg> test PreCICE