search

precice / PreCICE.jl

Julia language bindings for preCICE
GNU Lesser General Public License v3.0
11 stars 1 forks source link

Use precice develop for tests #49

Closed erikscheurer closed 1 year ago

erikscheurer commented 1 year ago

This PR modifies the tests to build precice develop instead of using the latest precice docker container as discussed in #47.

erikscheurer commented 1 year ago

At the moment, only the build test uses precice develop, this can easily be added, but may be open for debate as the python bindings to my understanding also use the docker container to test the solver dummies. The solverdummies would be the only test affected by this, as the others use a dummy solverinterface.

erikscheurer commented 1 year ago

We are now facing the issue, that the tests would run fine, but the versions of julia are outdated in a way, that leads the version of libstdc++ being newer in the container that we use (ubuntu-latest) than the ones shipped with julia. This error has been discussed in #44 and is now included in the julia bindings readme. It could be solved by preloading the system libraries, or by upgrading to newer julia versions compared to the system.

IshaanDesai commented 1 year ago

We are now facing the issue, that the tests would run fine, but the versions of julia are outdated in a way, that leads the version of libstdc++ being newer in the container that we use (ubuntu-latest) than the ones shipped with julia. This error has been discussed in #44 and is now included in the julia bindings readme. It could be solved by preloading the system libraries, or by upgrading to newer julia versions compared to the system.

I do not fully understand what can be a solution here. Are you suggesting that we drop support for older Julia versions? The test failures seem to not be related to Julia versions, because some tests for 1.6.0 pass and others fail.

erikscheurer commented 1 year ago

These changes break the tests on develop, but this should be fixed with #47. Due to older LTS versions of Julia, we have to preload libstdc++ and libcurl as described in #44 and now the README.