Optional argument relativ_read_time for waveform iteration.
The realization of the last point is still up for discussion. At the moment, I have an optional argument as -1.0 and a case distinction in the function itself which I think is not ideal.
In the python bindings the optional argument is None, however, in Julia, if you do this, you can't give the argument Type as Float64 because nothing is of type Nothing.
Another option is to simply use multiple dispatch for the function, so create multiple functions just like in the API, however, I did not get this to work at the moment. Trying to run the solverdummies, they could not find the correct function when the functioncall is separated.
This PR adds functions that are missing from the preCICE API.
This includes:
setMeshTetrahedron
andsetMeshTetrahedra
requiresMeshConnectivityFor
,setMeshAccessRegion
,getMeshVerticesAndIDs
relativ_read_time
for waveform iteration.The realization of the last point is still up for discussion. At the moment, I have an optional argument as -1.0 and a case distinction in the function itself which I think is not ideal. In the python bindings the optional argument is
None
, however, in Julia, if you do this, you can't give the argument Type asFloat64
becausenothing
is of typeNothing
. Another option is to simply use multiple dispatch for the function, so create multiple functions just like in the API, however, I did not get this to work at the moment. Trying to run the solverdummies, they could not find the correct function when the functioncall is separated.