search

precice / aste

Artificial Solver Testing Environment
GNU General Public License v3.0
10 stars 11 forks source link

Misleading error dealing with connectivity #144

Closed fsimonis closed 1 year ago

fsimonis commented 1 year ago

When working on #143, I noticed errors in the log despite all tests passing.

Turns out that the following emits an error: https://github.com/precice/aste/blob/fa7fe11287173b67ab0c1cf9510c027c1eb89103/src/mesh.cpp#L114

There are two problems here:

  1. This should be an info, or at most a warning, but no error.
  2. The execution continues, and the run succeeds, even though I would expect the run to fail.
davidscn commented 1 year ago

Yes, agree, was on my list.