Add Halton Mesh Generator

precice / aste

Artificial Solver Testing Environment

GNU General Public License v3.0

10 stars 11 forks source link

Add Halton Mesh Generator #155

Closed kursatyurt closed 1 year ago

kursatyurt commented 1 year ago

Main changes of this PR

This PR adds a 2D/3D mesh generator based on Halton numbers

Author's checklist

[x] I used the pre-commit hook and used pre-commit run --all to apply all available hooks.
[ ] I added a test to cover the proposed changes in our test suite.
[ ] I updated the documentation in docs/README.md.
[ ] I updated potential breaking changes in the tutorial precice/tutorials/aste-turbine.

davidscn commented 1 year ago

Could you add a few lines of documentation in the tools/mesh-generators/README.md stating what this script is and how to use it?

kursatyurt commented 1 year ago

Could you add a few lines of documentation in the tools/mesh-generators/README.md stating what this script is and how to use it?

It is done. I assumed that there is no connectivity required for this generator but if required I can also add Delaunay triangulation based connectivity information

davidscn commented 1 year ago

It is done. I assumed that there is no connectivity required for this generator but if required I can also add Delaunay triangulation based connectivity information

Could you do this in a follow-up?