Add connectivity to Halton Mesh Generator using Delaunay Triangulation

precice / aste

Artificial Solver Testing Environment

GNU General Public License v3.0

10 stars 11 forks source link

Add connectivity to Halton Mesh Generator using Delaunay Triangulation #157

Closed kursatyurt closed 1 year ago

kursatyurt commented 1 year ago

Main changes of this PR

This is a follow-up of #155, which adds connectivity information to Halton mesh in terms of Triangles and Tetrahedrons.

Author's checklist

[ ] I used the pre-commit hook and used pre-commit run --all to apply all available hooks.
[ ] I added a test to cover the proposed changes in our test suite.
[ ] I updated the documentation in docs/README.md.
[ ] I updated potential breaking changes in the tutorial precice/tutorials/aste-turbine.

kursatyurt commented 1 year ago

Some of the triangles are quite heavily distorted. Can we influence that? I could imagine that it might affect convergence.

That is quite normal we are just creating connectivity to given Halton points without introducing additional points. Some smoothing techniques might help but moves the points which I believe we don't want.

Could you also add a test similar to the NN test, where we use the halton mesh generator here (with connectivity), copy over the mesh file and perform a nearest-projection mapping?

On the way! Thanks for the recommendation.