Fixed DOF 0 bug & removed useless memcpy

[boris-martin]

Content

This PR seems to fix https://github.com/precice/calculix-adapter/issues/86 Following a suggestion from Matthias Freimuth, I removed a memcpy statement that seems to fixe the bug. Extensive testing is needed to ensure nothing else is broken. For the record, I am absolutely clueless as to 1) why removing this line fixes the bug 2) what was the purpose of it at first. So, mostly empirical stuff.

In my opinion, three things should be checked:

• Do all the tutorials work correctly with this change?
• Does this change fix the #86 bug wherever it occurs?
• Does this change impact memory consumption or something related? (I don't think so, but worth monitoring I guess)

@KyleDavisSA any idea what's happening here ?

Checklist

On my side:

Fixing the bug?

• [x] Perpendicular flap modified as suggested by Andres Pedemontes (see #86 ) is fixed.
• [x] The test case I introduced at https://github.com/precice/calculix-adapter/pull/92#issuecomment-1061668873 is fixed.

Non-regression

• [x] Does the perpendicular flap work as before ?
• [x] Does the heat exchanger work as before ?
• [x] Does the elastic-tube-3d work as before ?
• [x] Does the flow over heated plate work as before ?
• [ ] Does the partitioned beam work as before ?

Memory checks

Nothing done so far.

[MakisH]

@MatthiasFreimuth could you please help us understand this bugfix?

@boris-martin the "Does the partitioned beam work as before ?" box is still unticked. Does this mean you still want to test it, or that you saw issues?

If you say that this already fixed some known cases and it does not break others, let's merge it.

[boris-martin]

I didn't test it yet. But given the good results on other cases I don't expect any issue.