search

precice / calculix-adapter

preCICE-adapter for the CSM code CalculiX
GNU General Public License v3.0
52 stars 20 forks source link

Inconsistent lookup for read/write data in CHT and FSI #107

Open MakisH opened 2 years ago

MakisH commented 2 years ago

For temperature and heat flux, we are checking whether the field name is exactly matched in the config:

https://github.com/precice/calculix-adapter/blob/4496e8f160ec121481653baf44ec032813409ac6/adapter/PreciceInterface.c#L624

For other fields, we are checking whether the field name just starts with this prefix (similar behavior as in the OpenFOAM adapter), sometimes with a trailing -, sometimes without:

https://github.com/precice/calculix-adapter/blob/4496e8f160ec121481653baf44ec032813409ac6/adapter/PreciceInterface.c#L37

https://github.com/precice/calculix-adapter/blob/4496e8f160ec121481653baf44ec032813409ac6/adapter/PreciceInterface.c#L654

Additionally, data names are hard-coded for preCICE:

https://github.com/precice/calculix-adapter/blob/4496e8f160ec121481653baf44ec032813409ac6/adapter/PreciceInterface.c#L628

Finally, this error message is rather confusing:

https://github.com/precice/calculix-adapter/blob/4496e8f160ec121481653baf44ec032813409ac6/adapter/PreciceInterface.c#L662

"Does not exist" made me think that I still needed to specify it somewhere. However, it just means that the adapter does not know how to handle it.