Code refinement - Githubissues

precice / calculix-adapter

preCICE-adapter for the CSM code CalculiX

GNU General Public License v3.0

52 stars 20 forks source link

Code refinement #50

Closed IshaanDesai closed 3 years ago

IshaanDesai commented 3 years ago

This PR makes the 2D-3D implementation more readable and reverts a bug introduced in the PR: https://github.com/precice/calculix-adapter/pull/49 The bug was observed as the 3D_Tube tutorial case with OpenFOAM-CalculiX was failing. One major task:

[x] Ensure the 3D_Tube tutorial case works for the full duration. @DavidSCN can you please check this to rule out system specific behavior on my side?
[x] Ensure all FSI tutorial cases with CalculiX run and the results are reasonable

IshaanDesai commented 3 years ago

Running the perpendicular flap case (CalculiX - OpenFOAM) in the new restructured tutorials format here: https://github.com/precice/tutorials/pull/146 produces the result: which is reasonable and close to the reference result.

davidscn commented 3 years ago

...also tested the 3D until the end (n_t=100)... works (ignoring #51 ).