from fenics import * avoids publishing

precice / fenics-adapter

preCICE-adapter for the open source computing platform FEniCS

GNU Lesser General Public License v3.0

29 stars 15 forks source link

from fenics import * avoids publishing #126

Closed BenjaminRodenberg closed 3 years ago

BenjaminRodenberg commented 3 years ago

See https://github.com/precice/fenics-adapter/runs/2354843276

The changes introduced in #120 make fenics a dependency for being able to run setup.py, even if you don't actually need it. This breaks python3 setup.py sdist in our publishing pipeline. A workaround is to install FEniCS, but this is not a solution. We should find a different way to check for FEniCS (or at least find a way that does not influence sdist).

BenjaminRodenberg commented 3 years ago

Related to the v1.1.0 Release (https://github.com/precice/fenics-adapter/releases/tag/v1.1.0): I will now manually publish the package to PyPI. This allows me to circumvent the problem with the missing fenics.

BenjaminRodenberg commented 3 years ago

Related to #128