search

precice / fenics-adapter

preCICE-adapter for the open source computing platform FEniCS
GNU Lesser General Public License v3.0
27 stars 13 forks source link

Add check for mesh connectivity requirement before computing mesh edges #138

Closed IshaanDesai closed 1 year ago

IshaanDesai commented 2 years ago

In https://github.com/precice/precice/pull/1080 the API function isMeshConnectivityRequired() was added to check if mesh connectivity information is required by preCICE. This API function is now used to check whether the mesh edge computation is necessary.

uekerman commented 2 years ago

Please be aware that this means that the FEniCS adapter can no longer be used with preCICE < v2.3.

BenjaminRodenberg commented 2 years ago

Please be aware that this means that the FEniCS adapter can no longer be used with preCICE < v2.3.

Is it possible to only perform this check, if the preCICE version is recent enough and skip the check (and raise a warning?) if preCICE is < 2.3? pyprecice allows you to query the version of the bindings. So you should be able to check the version and act correspondingly inside the adapter.

IshaanDesai commented 1 year ago

Check added in https://github.com/precice/fenics-adapter/pull/153