search

precice / fenics-adapter

preCICE-adapter for the open source computing platform FEniCS
GNU Lesser General Public License v3.0
29 stars 15 forks source link

Compatibility update for v3.0.0 #153

Closed BenjaminRodenberg closed 1 year ago

BenjaminRodenberg commented 2 years ago

Ensures compatibility to precice:develop.

BenjaminRodenberg commented 1 year ago

I also added the v2.0.0 milestone here, because merging this PR would be breaking due to the changes in the action interface. We could also design this in a non-breaking fashion and hide the breaking changes of preCICE v3 inside of the adapter, but this might be more confusing than useful, I guess.

BenjaminRodenberg commented 1 year ago

Since this PR is already quite old: At the moment it is not on the first place of my list of priorities, but I expect to work with preCICE v3 + FEniCS within the next few months again. We can wait with this issue until then and I will occasionally review and merge. If something else pops up in the meantime, we can, of course, take care of this issue earlier.

IshaanDesai commented 1 year ago

Since this PR is already quite old: At the moment it is not on the first place of my list of priorities, but I expect to work with preCICE v3 + FEniCS within the next few months again. We can wait with this issue until then and I will occasionally review and merge. If something else pops up in the meantime, we can, of course, take care of this issue earlier.

I plan to work on this towards the end of this month. Most of the updates in the adapter itself have been done. The major work is actually in updating the tutorials in https://github.com/precice/tutorials/pull/333.

BenjaminRodenberg commented 1 year ago

@IshaanDesai I'll try to wrap this PR up soon. Main problem here are the unit tests. I assume the tutorial tests should work as soon as https://github.com/precice/tutorials/pull/333 is merged.