search

precice / fenics-adapter

preCICE-adapter for the open source computing platform FEniCS
GNU Lesser General Public License v3.0
29 stars 15 forks source link

precice/fenics-adapter:latest is not stable but the develop release #160

Closed valentin-seitz closed 1 year ago

valentin-seitz commented 1 year ago

Contrary to expectation the docker container published with tag latest seems to be the same as develop. It should however use the main/master to build. We need this to have a stable version compatible with precicev2 to test in the system tests.

MakisH commented 1 year ago

As we just discussed, here is the problem:

https://github.com/precice/fenics-adapter/blob/0a8f031b59f8b61af650a5e508a452a45165f56e/.github/workflows/build-docker.yml#L34

The GitHub Action always pushes to latest. This should only be true for the master branch, especially since there is a separate develop tag.

I suggest:

@IshaanDesai is there anything that relies on the latest tag of this image at the moment? Can we go ahead and do the above steps?

IshaanDesai commented 1 year ago

@IshaanDesai is there anything that relies on the latest tag of this image at the moment? Can we go ahead and do the above steps?

Not to my knowledge no. You can go ahead and do the above steps.