search

precice / fenics-adapter

preCICE-adapter for the open source computing platform FEniCS
GNU Lesser General Public License v3.0
29 stars 15 forks source link

Modify `setup.py` to avoid crash due to version 4.0.0 of `mpi4py` during installation #181

Closed NiklasVin closed 4 weeks ago

NiklasVin commented 1 month ago

This PR closes https://github.com/precice/fenics-adapter/issues/180.

setup_requires=['mpi4py<4'] is necessary as this requirement is needed for the imported FEniCS below.

BenjaminRodenberg commented 1 month ago

I removed the checks. See https://github.com/precice/fenics-adapter/pull/182.

NiklasVin commented 4 weeks ago

@BenjaminRodenberg So now, we only need to require

+ install_requires=['pyprecice>=3.0.0.0', 'scipy', 'numpy>=1.13.3, <2', 'mpi4py<4']

now?

BenjaminRodenberg commented 4 weeks ago

@BenjaminRodenberg So now, we only need to require

+ install_requires=['pyprecice>=3.0.0.0', 'scipy', 'numpy>=1.13.3, <2', 'mpi4py<4']

now?

I hope so.