search

precice / fenics-adapter

preCICE-adapter for the open source computing platform FEniCS
GNU Lesser General Public License v3.0
29 stars 15 forks source link

Create docker image `precice/fenics` #186

Open BenjaminRodenberg opened 1 week ago

BenjaminRodenberg commented 1 week ago

In https://github.com/precice/fenics-adapter/pull/174 I started using the image benjaminrodenberg/fenics. The corresponding dockerfile is provided under https://github.com/precice/fenics-adapter/blob/develop/tools/testing/docker/Dockerfile.

As mentioned by @IshaanDesai in https://github.com/precice/fenics-adapter/pull/184 we should host the image to precice/fenics. However, to me currently the workflow is a bit unclear. Should we generally move the corresponding dockerfile to https://github.com/precice/ci-images or is there another good place?

@MakisH any input from the systemtests bubble?

MakisH commented 4 days ago

In #174 I started using the image benjaminrodenberg/fenics. The corresponding dockerfile is provided under https://github.com/precice/fenics-adapter/blob/develop/tools/testing/docker/Dockerfile.

This place sounds right to me. For the system tests, we also store the respective Dockerfiles in the tutorials repository.

As mentioned by @IshaanDesai in #184 we should host the image to precice/fenics.

If you want to reuse of expose the image to the world, you can of course publish it to the GitHub container registry. This bypasses the discussion of what should be on Docker Hub and what not. We currently only have images with preCICE itself or its dependencies there.

However, to me currently the workflow is a bit unclear. Should we generally move the corresponding dockerfile to https://github.com/precice/ci-images or is there another good place?

The precice/ci-images repository is only for the images that preCICE (the core library) is using in its CI. However, it is common to get confused about the purpose of this repository, especially given our history with publishing (older) system tests images to Docker Hub.

@MakisH any input from the systemtests bubble?

We don't publish any images for the system tests, but we generate them on demand on the same system, reusing previously built layers. The multi-stage Dockerfile we currently use is stored in https://github.com/precice/tutorials/tree/develop/tools/tests/dockerfiles/ubuntu_2204