search

precice / fenics-adapter

preCICE-adapter for the open source computing platform FEniCS
GNU Lesser General Public License v3.0
29 stars 15 forks source link

Name of Attribute seems to be wrong #44

Closed moaxm closed 5 years ago

moaxm commented 5 years ago

Shouldn't this attribute be named "_read_function_type"?

https://github.com/precice/fenics-adapter/blob/721dac5a282bf833af436356355a131da84f8663/fenicsadapter/fenicsadapter.py#L282

BenjaminRodenberg commented 5 years ago

I agree. This looks wrong. We will check it. Thank you for opening this issue!

IshaanDesai commented 5 years ago

This is resolved by https://github.com/precice/fenics-adapter/commit/c28dbfc3a7b2cb16c0f176ee63280ca5e3b896a2