Cleaning the dirty fix in `adapter_core.py` - Githubissues

precice / fenicsx-adapter

Experimental preCICE-adapter for the open source computing platform FEniCSx

GNU Lesser General Public License v3.0

12 stars 7 forks source link

Cleaning the dirty fix in `adapter_core.py` #17

Open PhilipHildebrand opened 1 year ago

PhilipHildebrand commented 1 year ago

Right now, there is a dirty fix implemented for collecting the sampled data. Is there a particular reason for this?

edit by @BenjaminRodenberg

https://github.com/precice/fenicsx-adapter/blob/26678c169022bfc1776f1fa2d8bad40e4fbf825b/fenicsxprecice/adapter_core.py#L124-L134

arvedes commented 1 year ago

I implemented it when updating to v0.4, because the property fenicsx_function.x.array we used before was removed. See also: https://github.com/precice/fenicsx-adapter/pull/1#issuecomment-1163222926 https://github.com/precice/fenicsx-adapter/pull/1/commits/5af2065c8b8e4c53edcb877dee17e80724ab19a4