precice / fenicsx-adapter

Experimental preCICE-adapter for the open source computing platform FEniCSx
GNU Lesser General Public License v3.0
11 stars 6 forks source link

Develop existing FEniCS tutorials here #2

Closed BenjaminRodenberg closed 1 year ago

BenjaminRodenberg commented 2 years ago

To make development easier we develop the FEniCS-X tutorials here. As soon as this adapter is stable, we will migrate the tutorials to https://github.com/precice/tutorials. Our goal is to port all FEniCS tutorials to FEniCS-X. This is the complete list:

We should follow the folder structure and naming of the tutorials repository and put everything into the folder fenicsx-adapter/tutorials. The second participant (openfoam, su2...) and the preCICE configuration file should not be pushed into this repository, but just manually copied from the tutorials.

BenjaminRodenberg commented 1 year ago

15 and https://github.com/precice/tutorials/pull/317 represent a stable case for a limited set of features. We therefore decided to properly integrate the tutorial in the tutorials repository.

IshaanDesai commented 1 year ago

Now that we have ported the partitioned-heat-conduction tutorial from this repo into the tutorials, do we still want to pursue the strategy of developing tutorials here and porting them later?

BenjaminRodenberg commented 1 year ago

From my current perspective: No. I think the API is sufficiently stable that we should be able to develop the remaining tutorials directly in the tutorials repository. If we find out that we run into problems, we can just reopen this issue. We can still create an issue in the tutorials repo to keep track of the tutorials that still need to be ported. This is also a nice overview, if somebody wants to do a thesis or HiWi project on porting one of the tutorials.

IshaanDesai commented 1 year ago

Agreeing with @BenjaminRodenberg and hence closing this issue.