precice / micro-manager

A manager tool to facilitate two-scale coupling in multi-physics simulations using preCICE.
GNU Lesser General Public License v3.0
16 stars 11 forks source link

Overcounted active steps when using adaptivity in every implicit iteration #122

Closed mathiskelm closed 2 months ago

mathiskelm commented 3 months ago

When using adaptivity in every implicit iteration, the count of active steps is still incremented at the beginning of every time window when writing a checkpoint in micro_manager.py#L202. The increment should be guarded by the check for adaptivity based on time windows (line 169).

Note: The setting of active_sim_ids in between could also be moved to the conditional block. It is set separately for the case of adaptivity in every implicit iteration without being used in between.