precice / openfoam-adapter

OpenFOAM-preCICE adapter
https://precice.org/adapter-openfoam-overview.html
GNU General Public License v3.0
135 stars 80 forks source link

OpenFOAM 11 and higher does not ship an fvCFD.h #306

Open TEFEdotCC opened 1 year ago

TEFEdotCC commented 1 year ago

Since Version 11 fvCFD.h is removed. https://github.com/OpenFOAM/OpenFOAM-dev/tree/version-11/src/finiteVolume/cfdTools/general/include

Compilation with OpenFOAM-11 or OpenFOAM-dev leads into an error like


g++ -std=c++14 -m64 -DLIB_NAME=libpreciceAdapterFunctionObject.so -Dlinux64 -DWM_ARCH_OPTION=64 -DWM_DP -DWM_LABEL_SIZE=32 -Wall -Wextra -Wold-style-cast -Wnon-virtual-dtor -Wno-unused-parameter -Wno-invalid-offsetof -Wno-attributes -O3  -DNoRepository -ftemplate-depth-100 -I/opt/OpenFOAM-dev/src/finiteVolume/lnInclude -I/opt/OpenFOAM-dev/src/meshTools/lnInclude -I/opt/OpenFOAM-dev/src/transportModels/ -I/opt/OpenFOAM-dev/src/transportModels/incompressible/lnInclude -I/opt/OpenFOAM-dev/src/transportModels/compressible/lnInclude -I/opt/OpenFOAM-dev/src/transportModels/twoPhaseMixture/lnInclude -I/opt/OpenFOAM-dev/src/transportModels/interfaceProperties/lnInclude -I/opt/OpenFOAM-dev/src/transportModels/immiscibleIncompressibleTwoPhaseMixture/lnInclude -I/opt/OpenFOAM-dev/src/thermophysicalModels/basic/lnInclude -I/opt/OpenFOAM-dev/src/TurbulenceModels/turbulenceModels/lnInclude -I/opt/OpenFOAM-dev/src/TurbulenceModels/compressible/lnInclude -I/opt/OpenFOAM-dev/src/TurbulenceModels/incompressible/lnInclude -I/opt/OpenFOAM-dev/src/triSurface/lnInclude -I/usr/local/include  -I../  -IlnInclude -I. -I/opt/OpenFOAM-dev/src/OpenFOAM/lnInclude -I/opt/OpenFOAM-dev/src/OSspecific/POSIX/lnInclude   -fPIC -c preciceAdapterFunctionObject.C -o Make/linux64GccDPInt32Opt/preciceAdapterFunctionObject.o
In file included from Adapter.H:4,
                 from Adapter.C:1:
Interface.H:6:10: fatal error: fvCFD.H: No such file or directory
    6 | #include "fvCFD.H"
      |          ^~~~~~~~~
compilation terminated.
make: *** [/opt/OpenFOAM-dev/wmake/rules/General/transform:26: Make/linux64GccDPInt32Opt/Adapter.o] Error 1
make: *** Waiting for unfinished jobs....
In file included from FF/FF.H:4,
                 from FF/FF.C:1,
                 from FF/ModuleFF.C:2:
lnInclude/Interface.H:6:10: fatal error: fvCFD.H: No such file or directory
    6 | #include "fvCFD.H"
      |          ^~~~~~~~~
compilation terminated.
make: *** [/opt/OpenFOAM-dev/wmake/rules/General/transform:26: Make/linux64GccDPInt32Opt/FF/ModuleFF.o] Error 1
In file included from FSI/FSI.H:4,

....```
MakisH commented 10 months ago

Thank you, @TEFEdotCC! Did you need to change anything else to build with OpenFOAM 11?

I will start an OpenFOAM11 branch to push such changes.

efirvida commented 9 months ago

found this that may best helpful

https://github.com/search?q=repo%3AOpenFOAM%2FOpenFOAM-11+fvCFD.H&type=commits

seems that the fvCFD.H refactored.