precice / openfoam-adapter

OpenFOAM-preCICE adapter
https://precice.org/adapter-openfoam-overview.html
GNU General Public License v3.0
134 stars 77 forks source link

Release v1.3.1 #333

Closed MakisH closed 1 week ago

MakisH commented 1 week ago

Bugfix release, mainly fixing the volume-coupled-flow tutorial and the pre-commit hook.

Pending:

MakisH commented 1 week ago

The system tests are failing for the perpendicular-flap. I will look into the results in 1-2h, but this could just be a false alarm due to extra files being generated (currently only presumably so).

MakisH commented 1 week ago

(Edit: wrong versions are used)

The system tests are failing with actual numerical differences:

field-compare-1  | Comparing files in the directories '/runs/perpendicular-flap_fluid-openfoam-solid-calculix_2024-06-27-080907/precice-exports' and '/runs/perpendicular-flap_fluid-openfoam-solid-calculix_2024-06-27-080907/reference-results-unpacked/fluid-openfoam_solid-calculix'
field-compare-1  | 
field-compare-1  | Comparing '/runs/perpendicular-flap_fluid-openfoam-solid-calculix_2024-06-27-080907/precice-exports/Fluid-Mesh-Fluid.dt500.vtk'
field-compare-1  |       and '/runs/perpendicular-flap_fluid-openfoam-solid-calculix_2024-06-27-080907/reference-results-unpacked/fluid-openfoam_solid-calculix/Fluid-Mesh-Fluid.dt500.vtk'
field-compare-1  |   Reading '/runs/perpendicular-flap_fluid-openfoam-solid-calculix_2024-06-27-080907/precice-exports/Fluid-Mesh-Fluid.dt500.vtk'
field-compare-1  |   Reading '/runs/perpendicular-flap_fluid-openfoam-solid-calculix_2024-06-27-080907/reference-results-unpacked/fluid-openfoam_solid-calculix/Fluid-Mesh-Fluid.dt500.vtk'
field-compare-1  |    -- Comparing the field 'Force': FAILED
field-compare-1  |      -- Report: Deviation above tolerance detected -> [ 9.106287596856326   -0.05966103813265446  0.                 ] vs. [ 9.106277276921778   -0.05965746570060117  0.                 ] ([ 0.00 -0.01   inf] %)
field-compare-1  |      -- Predicate: DefaultEquality (abs_tol: 0., rel_tol: 3.e-07)
field-compare-1  |    -- Comparing the field 'Displacement': FAILED
field-compare-1  |      -- Report: Deviation above tolerance detected -> [0.0001706923844161843  0.00029547016613652846 0.                    ] vs. [0.00017066859115197518 0.00029542253804797254 0.                    ] ([0.01 0.02  inf] %)
field-compare-1  |      -- Predicate: DefaultEquality (abs_tol: 0., rel_tol: 3.e-07)
field-compare-1  |   File comparison FAILED with 1 PASSED / 2 FAILED / 0 SKIPPED
MakisH commented 1 week ago

I updated the preCICE version as well and the system tests pass. I should have done this here, so the tests helped!