search

precice / precice.github.io

The website of preCICE
https://precice.org/
12 stars 59 forks source link

Include instructions to remove .data() in readData function #313

Closed carme-hp closed 9 months ago

carme-hp commented 10 months ago

Calling .data() is not needed anymore because the data objects are now vectors. The porting guide did not have any instructions on this

carme-hp commented 10 months ago

I tried to do what @uekerman suggested. Let me know if this is better.

fsimonis commented 9 months ago

@carme-hp I think a major point of confusion is that we don't only change the interfaces from pointers to spans in the examples, but we simultaneously change the types that hold the data from C array to vector.

I attempted to make this a bit clearer in https://github.com/precice/precice.github.io/pull/316. Do you think this is easier to follow?

fsimonis commented 9 months ago

I missed the last commit. This makes things way cleaner. I'll merge this and then rebase further overhauls on it.