search

precice / precice.github.io

The website of preCICE
https://precice.org/
12 stars 56 forks source link

"Basic Tutorials" confuse the sidebar #376

Closed fsimonis closed 2 months ago

fsimonis commented 2 months ago

Opening a basic tutorial highlights it both in the "Basic Tutorials" and the "All Tutorials"

image

uekerman commented 2 months ago

wasn't this done on purpose in #372?

MakisH commented 2 months ago

It is not exactly on purpose, it is just a "feature" of how the relation of pages to sidebars is implemented, which assume that each page only appear once in the sidebar.

The difference now is that we list all tutorials (in groups), which is I think more important than the duplication issue.

What we can still do, is remove the "Basic cases" collection from the sidebar and let people discover those through the overview, or a dedicated page in the sidebar. But I think this is not a trivial discussion.

fsimonis commented 2 months ago

Technically, we could add a "link-only" key to the "basic" entries skip marking those links as active items

MakisH commented 2 months ago

I would need to tinker a bit to understand how this works. If you already know, please go ahead.

fsimonis commented 2 months ago

Solved by #377