precice / systemtests

Testing preCICE / solver combinations using Docker
GNU General Public License v3.0
3 stars 4 forks source link

Add commit tag or link to the commit of an adapter to system test log #104

Open IshaanDesai opened 4 years ago

IshaanDesai commented 4 years ago

When a system test is run on a commit of an adapter, it is difficult to trace back the exact commit of the adapter or the branch of the adapter and the corresponding system test used. If a link to the adapter commit is provided in the log of a system test, it can be referenced easily. Ideally two things can be included:

This commit with failed system test directs the user to this log but then it is confusing the trace the actual log of the system test.

BenjaminRodenberg commented 4 years ago

Just a few ideas how we could realize this:

Additionally, we should carefully think about which information to provide at which place: I think that we should provide the commit hashes of the complete software stack used for the test.

What do I mean with this? Usually a test relies on several pieces of software coming from different repositories with different revisions. For test fe-fe we, for example use precice, the python bindings, the fenics-adapter and, finally, the tutorials. Only the tutorials are actually cloned by the test. The rest is provided via dockerimages on dockerhub.

We have to be careful to not just shift the problem "it is difficult to trace back the exact commit of the adapter or the branch of the adapter and the corresponding system test used" to something like "it is difficult to find out which docker image we used for running the test and which code revision was used there". Example: https://github.com/precice/systemtests/issues/103.

fsimonis commented 4 years ago

What's missing is the link from the link from the trigger script by the adapter to the triggered build in the systemtests repo.

Once the trigger script prints the build id, then one can check the build in the systemtest Travis and the related output in the commit history of the precice_st_output repo

BenjaminRodenberg commented 4 years ago

What's missing is the link from the link from the trigger script by the adapter to the triggered build in the systemtests repo.

Once the trigger script prints the build id, then one can check the build in the systemtest Travis and the related output in the commit history of the precice_st_output repo

I am not sure if this is enough. What happens, for example, if a systemtest is triggered by commit xxxxxxx but before it actually executes another commit is pushed yyyyyyy. The systemtest was triggered by xxxxxxx, but it uses the latest version of the adapter, since it just clones master. This means even though being triggered by xxxxxxx, it will use the revision yyyyyyy.