precice / systemtests

Testing preCICE / solver combinations using Docker
GNU General Public License v3.0
3 stars 4 forks source link

Add revision info to docker images' name #193

Open BenjaminRodenberg opened 4 years ago

BenjaminRodenberg commented 4 years ago

Currently it is not easy to find out which code revision a docker image uses or to use a specific revision. precice/precice-ubuntu1604.home-develop, for example, might refer to any revision on develop. This becomes especially problematic, when a test fails, but it is unclear which revision certain parts of the toolchain are using.

An example implementation might be using the label of the image to identify the revision. Example: precice/precice-ubuntu1604.home-develop:9660959 will refer to an image that was built based on precice revision https://github.com/precice/precice/commit/9660959ecb73c91082e594f950f3c807aee3747a. Note that for the preCICE base images the situation is relatively simple. However, if we look at the adapter images there are much more relevant pieces of information and using the tag might not be sufficient; the solution proposed in #138 might be more appropriate.

Note that this change will cause many changes in our systemtests. Therefore, I would suggest to first carefully evaluate whether it is worth it and link related issues to this one.