precice / systemtests

Testing preCICE / solver combinations using Docker
GNU General Public License v3.0
3 stars 4 forks source link

Assertion fails in nutils-of test #258

Open Eder-K opened 3 years ago

Eder-K commented 3 years ago

See https://travis-ci.org/github/precice/systemtests/jobs/742004326#L636. the openfoam participant crashes shortly after starting.

This error just started popping up, directly after the adapter was switched from using precice-ubuntu1804.home-develop to precice-ubuntu1804.package-develop.

MakisH commented 3 years ago

This is the full message:

openfoam-adapter-outer    | ASSERTION FAILED
openfoam-adapter-outer    |   Location:          bool precice::xml::XMLTag::getBooleanAttributeValue(const string&) const
openfoam-adapter-outer    |   File:              /home/precice/precice/src/xml/XMLTag.cpp:133

and this is the origin:

https://github.com/precice/precice/blob/641e5057cb5d71d39ed43ae1dbc6af597b60bf52/src/xml/XMLTag.cpp#L133

Did anything change recently in the respective precice-config.xml?

Eder-K commented 3 years ago

Not on precice/tutorials, I can only assume this is entirely related to #256, which introduced the most recent change to the xml file: https://github.com/precice/systemtests/blob/5a78292267f61fc637c38c71c3e77376c3ba9155/tests/TestCompose_nutils-of/Dockerfile.tutorial_data#L12 Note that .home was unintentionally used instead of the intended .package image. This could explain why the error did not show up earlier.

Eder-K commented 3 years ago

I did find that the indentation of the inserted line was off by one space (the precice-config.xml for nutils-of uses a different indent size than other tests). However, this did not resolve the issue.