search

precice / tutorials

Various tutorial cases for the coupling library preCICE with real solvers. These files are meant to be rendered on precice.org, so don't look at the README files here.
https://www.precice.org/
GNU Lesser General Public License v3.0
105 stars 109 forks source link

elastic-tube-1d: Correct place for monolithic reference simulation? #254

Open BenjaminRodenberg opened 2 years ago

BenjaminRodenberg commented 2 years ago

There exists a monolithic reference case for the 1d-elastic-tube, which I used, for example, for the results presented in my talk "High-Order Time Stepping in Partitioned FSI with Black-Box Solvers". I think it would be useful to have a place to provide the monolithic reference simulation - potentially also with some documentation. I have the feeling that the tutorials are not the right place for these kind of examples where preCICE is actually not used at all (it's monolithic), but I cannot really imagine a better place, as well.

Currently, I have the monolithic version of the 1D tube in a private repository, but there is (as far as I know) no public place where this code is stored. I will attach a zip with the (very messy) source code to this issue for archiving and for providing some basis for the discussion.

preCICE-Experiments-master-1DTube.zip (:warning: use with care Code is from 2018 and outdated, but basic idea for the monolithic simulation should be clear)

MakisH commented 2 years ago

I assume this would again be essentially one / a couple of files, right? Why not put it in a tools/ directory in the elastic-tube-1d? I assmume that people would like to use that as a validation case.

uekerman commented 2 years ago

IIRC this should only be one additional term in the fluid equations, meaning a one-liner. Could be easier to add a parameter for this.

BenjaminRodenberg commented 4 hours ago

IIRC this should only be one additional term in the fluid equations, meaning a one-liner.

Generally that's right. Here's an excerpt from my thesis draft with the corresponding equations:

image

Main todos here are to update the code provided above and implement the monolithic solver somewhere (either inline as suggested by @uekerman or in tools as suggested by @MakisH). Both solutions are fine from my perspective.

BenjaminRodenberg commented 4 hours ago

Labeled this issue as student, because I think the overall approach and goal is quite clear. But we still have to do it and make sure that the results are correct in the end.