precice / tutorials

Various tutorial cases for the coupling library preCICE with real solvers. These files are meant to be rendered on precice.org, so don't look at the README files here.
https://www.precice.org/
GNU Lesser General Public License v3.0
102 stars 106 forks source link

Inconsistencies in structure of tutorials #461

Closed MakisH closed 5 months ago

MakisH commented 7 months ago

Follow-up of https://github.com/precice/tutorials/issues/228. The structure is documented in the website and clarified in https://github.com/precice/precice.github.io/pull/331.

The following tutorials need updates:

I would still consider the aste-turbine to be a very special case that is not meant to be extended or repeated in other tutorials.

Please comment regarding which cases you would like to port. No need to port every tutorial at once, but let's try to have a consistent structure until the next release of the tutorials.

BenjaminRodenberg commented 7 months ago

I don't want to prioritize this before my thesis is submitted or at least close to submission. I think this is also something that could be easily done by a research assistant and not urgent.

MakisH commented 7 months ago

You mean that you don't want to work on it now, or that you don't want that the structure changes now?

BenjaminRodenberg commented 7 months ago

I'm fine with the structural changes and we can also implement them rather sooner than later, but I don't have time to do it myself now.

If I stumble across a point where I can briefly do it anyway, I will do it occasionally (e.g. https://github.com/precice/tutorials/commit/459ab90fd803de85a5c370430a11693277d70c83).

MakisH commented 7 months ago

Thank you, I can also take over work packages on this.

uekerman commented 6 months ago

Please don't update the oscillator before merging #466