search

precisely / curious2

0 stars 0 forks source link

Discussion editing enhancements #938

Closed visheshd closed 8 years ago

visheshd commented 8 years ago

Key changes

  1. Added an auto-resize jQuery plugin to add that feature to any input easily
  2. queueJSON now supports a spinner as a user feedback when needed

    Screenshots

    Description in focus

1-inline-description-on-focus

Description NOT in focus

2-inline-description-when-not-focused

Description auto expands

3-inline-description-with-auto-expandable-textarea

Editing the description

Currently kept it in the modal since the title was already there. We can convert both to inline, 4-option-to-edit-the-description-also

Comment form

5-auto-expanding-input-on-new-comment

Comment submission

6-user-feedback-on-a-new-comment

Moved the edit icons to only appear on hover

7-option-to-edit-a-comment

Inline editing a comment

8-inline-editing-a-comment

Similar commenting changes on the listing page

9-auto-expanding-input-in-feeds-listing-page

Preventing multiple clicks on Trackathon creation

10-trackathon-creation-feedback

syntheticzero commented 8 years ago

Okay --- looking over the summary here, it looks quite good --- however, as I mentioned on Slack --- let's stay consistent here. Enter should always submit the form

syntheticzero commented 8 years ago

Sorry submitted before I was ready. Enter should always submit the form, whether it is editing the description or editing a comment. No need for a check affordance. If the user wants to enter multiple paragraphs they can use shift-enter. I like the cross for clearing the text, however.

visheshd commented 8 years ago

Sure, will get that in by your morning

sagrawal31 commented 8 years ago

Done with that change. Now pressing Enter will always submit the form and Shift + Enter will insert a new line. Also, got rid of that check affordance. cc @syntheticzero

11-modification-in-description-form

syntheticzero commented 8 years ago

Great. merging.