precision-sustainable-ag / Hotline-Issues

Current protocols for the on-farm trial network
MIT License
1 stars 0 forks source link

PM3D Multi-OAK "Live Feed" camera toolbar won't collapse #463

Open jordannicolette opened 2 days ago

jordannicolette commented 2 days ago

Describe the bug When connected to a PM3D multi-oak system, and you open the camera list on the left, the list cannot close unless the page is refreshed. This becomes an issue when you "start" a flag in the data, toggle to a different camera, then can't collapse the side bar to flag the end of collection. Then when refreshing while before hitting "stop" the newly load pages prompts the user to "start" again.

To Reproduce Steps to reproduce the behavior:

  1. Go to http://192.168.50.5/ while connected to the system
  2. Click on 'START'
  3. Open the camera sidebar on the left
  4. try to close camera sidebar or hit "STOP"

Expected behavior Camera sidebar should collapse

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Button to collapse sidebar would solve issue

alexrallen commented 1 day ago

Frontend issue. Forwarding to @mikahpinegar for triage.

mikahpinegar commented 1 day ago

@akshat22 can you make a hotfix pr for this? you should be able to copy this feature in the rafiki branch that allows clicking anywhere outside of the camera list or other modals to auto close it

mikahpinegar commented 1 day ago

@jordannicolette are you using your phone for accessing the app? @alexrallen are we intending to have people access the system on smartphones? it's not currently built with that in mind and is geared towards tablet sized devices.

akshat22 commented 1 day ago

@jordannicolette there should have been a dismiss button below the camera list which dismisses the dialog. Was it not visible on the device that you tested on?

jordannicolette commented 1 day ago

@jordannicolette are you using your phone for accessing the app? @alexrallen are we intending to have people access the system on smartphones? it's not currently built with that in mind and is geared towards tablet sized devices.

I was using my laptop originally where I had the issue, and then tested it on my IPhone where it was still an issue

jordannicolette commented 1 day ago

@jordannicolette there should have been a dismiss button below the camera list which dismisses the dialog. Was it not visible on the device that you tested on?

That button was not visible on either device. The last button on the list I believe was "Get Camera List". I believe I scrolled to the bottom but we'll have to check when we go out next @zackgrzywacz

akshat22 commented 1 day ago

@jordannicolette Can you also share a screenshot of the screen with the dialog open whenever you get the chance?