search

precision-sustainable-ag / dst-seedcalc

2 stars 0 forks source link

updated site conditions with red error border and fixed tilling check… #208

Closed Adamws33 closed 5 months ago

Adamws33 commented 6 months ago

added red border when site conditions are empty updated tiling check logic to display correctly, and be visible correctly. made prop name for emptyWarning for text and dropdown removed "your improved soil..." when the tiling check isnt selected.

azure-pipelines[bot] commented 6 months ago

Your review app has been deployed and is available at 'http://51.8.8.49:80'.

Learn More about how to test and provide feedback for the app.

azure-pipelines[bot] commented 6 months ago

Your review app has been deployed and is available at 'http://51.8.8.49:80'.

Learn More about how to test and provide feedback for the app.

YazidZidane commented 6 months ago

I found a problem when testing Site Conditions page, when I select any locations on the map, and the Soil Drainage dropdown will be populated, but after I fill the rest for the form I will not be able to go to next step. I found that the soilDrainage redux value is not filled, I think it's because the useEffect in form.js set the redux to empty. One possible solution I can think of is to break the function in this useEffect to handleSoilDrainage() and handleTileDrainage(), since these are only places where tileDrainage will be updated

Adamws33 commented 6 months ago

I found a problem when testing Site Conditions page, when I select any locations on the map, and the Soil Drainage dropdown will be populated, but after I fill the rest for the form I will not be able to go to next step. I found that the soilDrainage redux value is not filled, I think it's because the useEffect in form.js set the redux to empty. One possible solution I can think of is to break the function in this useEffect to handleSoilDrainage() and handleTileDrainage(), since these are only places where tileDrainage will be updated

This was happening because the state variable i created was set to "" and not the initial value of the soil drainage. the 2nd part of my if statement in the useEffect sets the soilDrianage. How i made my updates i didn't realize the previous soil drainage was there. but that has all been updated now.

azure-pipelines[bot] commented 6 months ago

Your review app has been deployed and is available at 'http://51.8.8.49:80'.

Learn More about how to test and provide feedback for the app.

azure-pipelines[bot] commented 6 months ago

Your review app has been deployed and is available at 'http://51.8.8.49:80'.

Learn More about how to test and provide feedback for the app.