precision-sustainable-ag / dst-selector

https://covercrop-selector.org
MIT License
3 stars 1 forks source link

Add snackbar message for user history #633

Closed YazidZidane closed 4 months ago

YazidZidane commented 4 months ago
mikahpinegar commented 4 months ago

Your review app has been deployed and is available at 'http://51.8.253.125:80'.

Learn More about how to test and provide feedback for the app.

mikahpinegar commented 4 months ago

Your review app has been deployed and is available at 'http://51.8.253.125:80'.

Learn More about how to test and provide feedback for the app.

Adamws33 commented 4 months ago

The first alert says "your location has been saved" and all of the rest say "History Updated". Can we update each of them to be a more clear message for what has just been updated?

Adamws33 commented 4 months ago

One thing i noticed is that when i add crops from the browse and then hit restart and recall that history the crops i added are included in the history. But if i go through the get a recommendation and i add crops i still get the alert "[crop name] was added" but the crops are not getting saved to my history unless i navigate away from the page to my list before restarting.

Adamws33 commented 4 months ago

I think this may be a bug from the user history and not from this ticket but something i found. I went to create a new history, then selected Ohio, then selected Browse Cover Crops then selected 3 random crops. I then hit the get a recommendation button which then forces a reset and when i went to go select the history i created i noticed all of my histories were gone. A refresh of the page corrected things and the history saved as expected. image

YazidZidane commented 4 months ago

The first alert says "your location has been saved" and all of the rest say "History Updated". Can we update each of them to be a more clear message for what has just been updated?

One thing i noticed is that when i add crops from the browse and then hit restart and recall that history the crops i added are included in the history. But if i go through the get a recommendation and i add crops i still get the alert "[crop name] was added" but the crops are not getting saved to my history unless i navigate away from the page to my list before restarting.

Currently the history is only saved upon page change so if you don't switch the page it will not be saved, and thus all of the snackbar message says 'History saved/updated', except for the location one which is already existed before.

Edit: I do found a way to trigger save user history upon select crops, should I add them when a crop is added?

mikahpinegar commented 4 months ago

Your review app has been deployed and is available at 'http://,51.8.253.125:80'.

Learn More about how to test and provide feedback for the app.

mikahpinegar commented 4 months ago

Your review app has been deployed and is available at 'http://51.8.253.125:80'.

Learn More about how to test and provide feedback for the app.

Adamws33 commented 4 months ago

The first alert says "your location has been saved" and all of the rest say "History Updated". Can we update each of them to be a more clear message for what has just been updated?

One thing i noticed is that when i add crops from the browse and then hit restart and recall that history the crops i added are included in the history. But if i go through the get a recommendation and i add crops i still get the alert "[crop name] was added" but the crops are not getting saved to my history unless i navigate away from the page to my list before restarting.

Currently the history is only saved upon page change so if you don't switch the page it will not be saved, and thus all of the snackbar message says 'History saved/updated', except for the location one which is already existed before.

Edit: I do found a way to trigger save user history upon select crops, should I add them when a crop is added?

Yes please. That way it is consistent with the browse section too

mikahpinegar commented 4 months ago

Your review app has been deployed and is available at 'http://51.8.253.125:80'.

Learn More about how to test and provide feedback for the app.

mikahpinegar commented 4 months ago

Your review app has been deployed and is available at 'http://51.8.253.125:80'.

Learn More about how to test and provide feedback for the app.

YazidZidane commented 4 months ago

The first alert says "your location has been saved" and all of the rest say "History Updated". Can we update each of them to be a more clear message for what has just been updated?

One thing i noticed is that when i add crops from the browse and then hit restart and recall that history the crops i added are included in the history. But if i go through the get a recommendation and i add crops i still get the alert "[crop name] was added" but the crops are not getting saved to my history unless i navigate away from the page to my list before restarting.

Currently the history is only saved upon page change so if you don't switch the page it will not be saved, and thus all of the snackbar message says 'History saved/updated', except for the location one which is already existed before. Edit: I do found a way to trigger save user history upon select crops, should I add them when a crop is added?

Yes please. That way it is consistent with the browse section too

I have updated saving history when select/unselect crops. I haven't added for other selections since I think it's still efficient to save by step changes, but it's also possible to add these changes.

Adamws33 commented 4 months ago

The first alert says "your location has been saved" and all of the rest say "History Updated". Can we update each of them to be a more clear message for what has just been updated?

One thing i noticed is that when i add crops from the browse and then hit restart and recall that history the crops i added are included in the history. But if i go through the get a recommendation and i add crops i still get the alert "[crop name] was added" but the crops are not getting saved to my history unless i navigate away from the page to my list before restarting.

Currently the history is only saved upon page change so if you don't switch the page it will not be saved, and thus all of the snackbar message says 'History saved/updated', except for the location one which is already existed before. Edit: I do found a way to trigger save user history upon select crops, should I add them when a crop is added?

Yes please. That way it is consistent with the browse section too

I have updated saving history when select/unselect crops. I haven't added for other selections since I think it's still efficient to save by step changes, but it's also possible to add these changes.

When i add a crop to my list on both the browse and recommend section i get this error. This is when i have not selected a history or am not currently creating one but i am logged in, this error also happens when logged out. When i am logged in and creating a new history or have imported a history it is working just fine. image

mikahpinegar commented 4 months ago

Your review app has been deployed and is available at 'http://51.8.253.125:80'.

Learn More about how to test and provide feedback for the app.

mikahpinegar commented 4 months ago

Your review app has been deployed and is available at 'http://51.8.253.125:80'.

Learn More about how to test and provide feedback for the app.

Adamws33 commented 4 months ago

Ok one more thing i noticed. When you are saving a user history and you select a state.. then browse and you select a few crops. you can then resrart and select that user history and it will populate in the Recommend section with those crops loaded. This is fine because the user history prevents you from changing the state. But the little 3 apears over the next buttons. This isnt expected till the final step in the crop view pages. Can you update the next button to only show this number when on that final step. image

mikahpinegar commented 4 months ago

Your review app has been deployed and is available at 'http://51.8.253.125:80'.

Learn More about how to test and provide feedback for the app.

mikahpinegar commented 4 months ago

Your review app has been deployed and is available at 'http://51.8.253.125:80'.

Learn More about how to test and provide feedback for the app.